Feature: Add additional tests & fix e2e pipeline #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 63.5 kB ℹ️ View Unchanged
|
|
Hey @Firestorm980 👋 This is really cool!!! Is there any reason this is still marked as draft? 🤔 from what I can tell this is all passing and working as indended |
fabiankaegy
added
[Type] Enhancement
@fabiankaegy Just that I was still actively adding tests. I think if we got it updated with the base branch though, we can take out of draft and review. |
|
Okay cool :) Updated and reviewing now. We can always add more tests in separate PR's :) |
fabiankaegy
approved these changes
Jul 9, 2024
Passing run #917 ↗︎
Details:
Review all test suite changes for PR #336 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Tests overhaul for the repo. This fixes an issue with e2e testing on GitHub workflows as well as adds many additional automated tests to Cypress for components that didn't previously have them. Should help identify if there are any breaking changes in the future.
How to test the Change
npm start-test-envto start the WP environmentnpm cypress:runWorkflow testing should be checked using the repos GitHub actions. Using the
actpackage locally with Cypress appears to have some outstanding issues, unfortunately, but they are unrelated to these changes.Changelog Entry
Added - Tests for
ColorSettings,Counter,RichTextCharacterLimit,PostTitle,PostFeaturedImage,PostMetaAdded - More standardized testing commands (in line with our other repos)
Fixed - e2e tests only working sporadically in the GitHub workflow.
Credits
Props @Firestorm980
Checklist: